Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The utility class ".border" is using a "fixed" color #22993

Closed
envolute opened this issue Jul 4, 2017 · 3 comments
Closed

The utility class ".border" is using a "fixed" color #22993

envolute opened this issue Jul 4, 2017 · 3 comments

Comments

@envolute
Copy link
Contributor

envolute commented Jul 4, 2017

The class ".border" (css/utilities/_borders.scss) is set the border-color to "$gray-200".
So I see that it would be nice to create a variable for the border color "$border-color". Because the default border should not always be "gray-200".
Another thing, there is a "$border-width" variable. Would not it be better to use this variable to set the default width of the border?

In this case we would have in "_variables.scss"

$border-width: 1px !default;
$border-color: $gray-200 !default;

And in "_borders.scss"
.border { border: $border-width solid $border-color !important; }

@gijsbotje
Copy link
Contributor

might i suggest classes like .border-success and .border-danger?

@envolute
Copy link
Contributor Author

envolute commented Jul 6, 2017

If you're talking about classes like ".border-success, .border-primary, .border-danger", they are already defined!
The question here is referring to the "default" border. Let's say I want the default border to be darker, something like gray-400. The way it is has no way to change without an additional class or change the file "_borders.scss" (which I would not do)
Well, this change is quite obvious to me. I think, for my part, it was more a warning than a suggestion ...

@gijsbotje
Copy link
Contributor

gijsbotje commented Jul 6, 2017

aah sorry, you're right. i hadn't noticed them untill now
as for your issue, i agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants