Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invisible border of input-group in inverse navbar #21098

Closed
fredgate opened this issue Nov 8, 2016 · 5 comments
Closed

Invisible border of input-group in inverse navbar #21098

fredgate opened this issue Nov 8, 2016 · 5 comments

Comments

@fredgate
Copy link

fredgate commented Nov 8, 2016

When in a inverse navbar I add a input-group containing a input and an add-on, the border of the input is badly rendered while the border of the add-on is ok. If the navbar is not inverse, all is fine.
Here is a jsfiddle showing the problem : https://jsfiddle.net/mw7ts10m/

temp
The problem is with version alpha 5 (tested on firefox and IE11).

With the alpha 2 version, the borders was well rendered, as showed in this jsfiddle : https://jsfiddle.net/mw7ts10m/2/
It seems broken since alpha 3.

@abvalentine
Copy link
Contributor

abvalentine commented Nov 20, 2016

The reason is moving to a translucent border color in commit c3e4cbd
This commit also affects .custom-select and .input-group-addon.

@abvalentine
Copy link
Contributor

The commit was a fix for #19136. Maybe we should make semi-transparent a border of add-on.

@fredgate
Copy link
Author

Here is the previous rendering with version aplha 2 :

issue

@fredgate
Copy link
Author

I tried to add background-clip: padding-box; to input-group-addon.
At first glance, it was not too bad, although the separator between the addon and the input is not very pretty. But there is another problem. When the input receives the focus, the blue border that it gains produces the inverse effect : the input seems higher than the addon.

Here is a screenshot showing the problem :

issue

@tillkruss
Copy link

Seeing the same issue.

screen shot 2017-01-01 at 2 18 39 pm

screen shot 2017-01-01 at 2 18 57 pm

@mdo mdo modified the milestone: v4.0.0-beta Jan 2, 2017
twbs-savage pushed a commit to twbs-savage/bootstrap that referenced this issue Apr 6, 2017
Add `$btn-secondary-border` border color for form control in input group in the navbar when there is a dark background.

Because the normal border color is `rgba(0,0,0,.15)` and depend of the background color the input in input group seems to have no border.

Fix twbs#21098
Close twbs#21318
nwoltman added a commit to nwoltman/bootstrap that referenced this issue May 13, 2017
c3e4cbd changed the border of input elements to be translucent. This commit makes
input group elements and custom form inputs follow the same pattern.

Fixes twbs#21098
nwoltman added a commit to nwoltman/bootstrap that referenced this issue May 13, 2017
c3e4cbd changed the border of input elements to be translucent. This commit makes
input group elements and custom form inputs follow the same pattern.

Fixes twbs#21098
@mdo mdo modified the milestones: v4.0.0-beta.2, v4.0.0-beta May 26, 2017
@mdo mdo added the has-pr label May 26, 2017
@mdo mdo removed this from the v4.0.0-beta.2 milestone Jun 18, 2017
@mdo mdo mentioned this issue Aug 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants