Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider alternative method of styling toggle buttons (don't use data-toggle="buttons" for styling) #20359

Closed
pkozlowski-opensource opened this issue Jul 25, 2016 · 2 comments
Labels

Comments

@pkozlowski-opensource
Copy link

I'm part of the angular-ui/bootstrap team working on native Angular directives using Bootstrap markup.

As part of the effort to migrate to Angular 2 and Bootstrap 4 we've started the ng-bootstrap project here: https://ng-bootstrap.github.io

So far the progress is very smooth and I couldn't be more grateful for all the splendid job that you are doing here on Bootstrap 4.

There is just one glitch that we've encounter so far: when using button groups (ex. check-box ) we need to add data-toggle="buttons" to get proper styling on inputs. While I totally see how it works perfectly with provided jQuery plugins, it is not very intuitive for people not using jQuery but rather using a framework like Angular or React.

Would you consider another method of styling toggle buttons, for example using a dedicated CSS class (eg. .toggle-buttons)?

@cvrebert
Copy link
Collaborator

We're trying to axe the buttons.js JavaScript entirely in v4 and replace it with a pure-CSS + :checked-based approach. See #18874.
I believe that should adequately address your concern?

@pkozlowski-opensource
Copy link
Author

@cvrebert yes, #18874 would solve my problem and will make the whole integration on our side trivial 👍

Going to close this one and keep an eye on #18874

Thnx for the quick answer and all the awesome work you guys are doing here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants