Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate border-color & filter properties in .btn-default's CSS #19151

Closed
gabriellupu opened this issue Feb 10, 2016 · 3 comments
Closed

Duplicate border-color & filter properties in .btn-default's CSS #19151

gabriellupu opened this issue Feb 10, 2016 · 3 comments
Labels

Comments

@gabriellupu
Copy link

In dist/css/bootstrap-theme.css:64 for .btn-default there are duplicated CSS rules for filter & border-color :

.btn-default {
  text-shadow: 0 1px 0 #fff;
  background-image: -webkit-linear-gradient(top, #fff 0%, #e0e0e0 100%);
  background-image:      -o-linear-gradient(top, #fff 0%, #e0e0e0 100%);
  background-image: -webkit-gradient(linear, left top, left bottom, from(#fff), to(#e0e0e0));
  background-image:         linear-gradient(to bottom, #fff 0%, #e0e0e0 100%);
  filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#ffffffff', endColorstr='#ffe0e0e0', GradientType=0);
->filter: progid:DXImageTransform.Microsoft.gradient(enabled = false);
  background-repeat: repeat-x;
  border-color: #dbdbdb;
->border-color: #ccc;
}
@ameya-pandilwar
Copy link
Contributor

The duplicate 'border-color' property has been fixed. However, the 'filter' property still remains as it was introduced in this fix - #10620

@cvrebert cvrebert changed the title Duplicated css properties Duplicate border-color & filter properties in .btn-default's CSS Feb 14, 2016
@mdo
Copy link
Member

mdo commented Feb 17, 2016

Going to punt as a won't fix. Honestly comes down to a lack of interest, low priority (meaning not a major/breaking bug), and lack of time given the emphasis on v4.

Those overrides—at least for the border-color are intentional as the mixins we used in the theme.less file didn't cut it for the default button styles. Had to tweak some things to get it looking/feeling better.

@mdo mdo closed this as completed Feb 17, 2016
@gabriellupu
Copy link
Author

Thanks for the effort and feedback !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants