From c70b043a76764b842c732417fb32325ae2d1ac56 Mon Sep 17 00:00:00 2001 From: "Patrick H. Lauke" Date: Thu, 6 Dec 2018 11:30:12 +0000 Subject: [PATCH] Remove nonsensical boolean check (#27787) ...as it always evaluates to true --- js/src/dropdown.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/js/src/dropdown.js b/js/src/dropdown.js index d8fe5fdba1df..0c13b2c5eb5d 100644 --- a/js/src/dropdown.js +++ b/js/src/dropdown.js @@ -468,8 +468,7 @@ class Dropdown { const parent = Dropdown._getParentFromElement(this) const isActive = $(parent).hasClass(ClassName.SHOW) - if (!isActive && (event.which !== ESCAPE_KEYCODE || event.which !== SPACE_KEYCODE) || - isActive && (event.which === ESCAPE_KEYCODE || event.which === SPACE_KEYCODE)) { + if (!isActive || isActive && (event.which === ESCAPE_KEYCODE || event.which === SPACE_KEYCODE)) { if (event.which === ESCAPE_KEYCODE) { const toggle = parent.querySelector(Selector.DATA_TOGGLE) $(toggle).trigger('focus')