Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Mail UI components to take actions instead of ViewModels #8527

Open
charlag opened this issue Feb 13, 2025 · 0 comments · May be fixed by #8528
Open

Refactor Mail UI components to take actions instead of ViewModels #8527

charlag opened this issue Feb 13, 2025 · 0 comments · May be fixed by #8528
Assignees

Comments

@charlag
Copy link
Contributor

charlag commented Feb 13, 2025

Currently a lot of Ui components do execute the necessary actions on their own. This was done as a code reuse between mail and search.
Unfortunately, this lead to a few issues:

  • We trigger the same action from a lot of places (desktop toolbar, mail viewer header, mobile toolbars, shortcuts) and we have to implement the same code a lot of times
  • When there are differences between mail and search view it complicated the control flow

Instead we would like to pass individual actions to the components that need them and having them implemented at the common ancestor (e.g. top-level view). This means some duplication between mail/search but less duplication for each individual component.

Estimated: 8h

@paw-hub paw-hub self-assigned this Feb 13, 2025
@paw-hub paw-hub linked a pull request Feb 13, 2025 that will close this issue
@paw-hub paw-hub linked a pull request Feb 13, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants