-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Location: response valid with PATCH response? #155
Comments
shortly after posting this question, I realized that the client might not receive the server's response to a partial (interrupted) |
Exactly, you came to the right conclusion :) When dealing with unreliable networks you need to have a constant endpoint that does not change to synchronize the client's and server's progress. So changing URLs are not possible with the current design of tus. |
thank you for the quick response! |
I'd like to come back to this please once more: |
Yes, it does make sense. But to be honest, this sounds very application-specific and I am not sure this is a good fit for the specification in general. |
I would not think support for content based URLs was particularly specific. It is a generally useful concept to implement de-duplication on the object level. |
That's a good argument. Feel free to open a PR for this, if you want to :) |
I am working on a varnish cache vmod implementation of a TUS proxy, acting as a TUS server towards clients, to be released as open source.
One particular aspect of the use case of the initial sponsor of this implementation is to always store objects with their content hash as the last path element.
Determining the hash is possible at creation time for
POST
sUpload-Concat: final;...
Yet with
PATCH
, the location of the object would change with every uploaded chunk (except for an empty one), so I wonder if updating it by sending aLocation:
response header would be allowed by the protocol.My take is that as
PATCH
is serialized by design, the protocol could require clients to accept updates to the location, but I have not found any mention of this case and would thus appreciate clarification.The text was updated successfully, but these errors were encountered: