Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to turnerlabs and removes unnecessary cmds #2

Merged
merged 3 commits into from
May 2, 2018
Merged

Conversation

jritsema
Copy link

@jritsema jritsema commented May 2, 2018

No description provided.

Copy link

@wilsonodk wilsonodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Couple places where we will need to decide how to update going forward.

  • CONTRIBUTING.md still has links to github.com/jpignata. And we need to put in a Turner specific document.

  • doc/website still has links to github.com/jpignata. Again, we may decide to do this a bit differently.

@jritsema
Copy link
Author

jritsema commented May 2, 2018

Good catch @wilsonodk. How's this?

@wilsonodk
Copy link

@jritsema Looks like some of the links in the contributing document aren't working correctly.

@jritsema jritsema merged commit d0c7cb4 into develop May 2, 2018
@jritsema jritsema deleted the turnerlabs branch May 2, 2018 16:48
@lukeburns
Copy link

Why is fargate service create unnecessary? Is this cli just for managing existing services?

@jritsema
Copy link
Author

jritsema commented Jan 9, 2020

Hi @lukeburns. Yes, we prefer using IaC tools for managing [what we consider to be] the infrastructure components. This CLI is focused on the "application" concerns like deploying images, environment variables, and secrets on top of infrastructure and managing running applications (ps, logs, restart, etc).

Our strategy has been to use Terraform templates like these for provisioning different types of infrastructure stacks.

Our fargate-create CLI tool brings these infrastructure and application components together and lets you provision new apps.

Does that make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants