Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nonsense calibration if sweep is paused before the calibration #123

Open
yarda opened this issue Mar 6, 2020 · 3 comments
Open

Nonsense calibration if sweep is paused before the calibration #123

yarda opened this issue Mar 6, 2020 · 3 comments

Comments

@yarda
Copy link

yarda commented Mar 6, 2020 •
edited
Loading

Reproducer:

  1. pause sweep (stimulus/pause sweep)
  2. do all calibration steps while the sweep is paused (cal/calibrate)

This will result in nonsense calibration and very long numbers for SWR (with many digits overflowing the display width).

The firmware should either unpause the sweep before the calibration or inform user that the calibration cannot be done with the paused sweep (and it shouldn't allow to proceed).
@yarda
Copy link
Author

yarda commented Mar 6, 2020

FW 0.7.0-20200223

@yarda yarda changed the title Nonsense calibration if sweep is paused before calibration Nonsense calibration if sweep is paused before the calibration Mar 6, 2020
@DiSlord
Copy link
Contributor

DiSlord commented Mar 7, 2020

Thanks, i add sweep operation for collect data in next Pull Request to fix it

@DiSlord
Copy link
Contributor

DiSlord commented Mar 7, 2020

Revert add this feature, need find better solution :(

@DiSlord DiSlord mentioned this issue Mar 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DiSlord @yarda