Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verifing default keybindings wrapper fails #341

Closed
tshino opened this issue Mar 2, 2024 · 0 comments · Fixed by #342
Closed

Verifing default keybindings wrapper fails #341

tshino opened this issue Mar 2, 2024 · 0 comments · Fixed by #342
Labels
bug Something isn't working

Comments

@tshino
Copy link
Owner

tshino commented Mar 2, 2024

This is the cause of the failure in CI.
https://github.com/tshino/vscode-kb-macro/actions/workflows/get-default-keybindings.yml

It seems verify_wrapper.js fails if some specific platform contexts, like isLinux, are contained in the default keybindings. And that condition meets for VS Code 1.87.0.

Following lines appears in the default keybindings for VS Code 1.87.0 for Linux and Windows.

{ "key": "ctrl+up",               "command": "chat.action.focus",
                                     "when": "inChatInput && isLinux || inChatInput && isWindows" },

This is redundant and unexpected for the script, but it is still valid and the script should not fail.

@tshino tshino added the bug Something isn't working label Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant