Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual confirmation that the Wake Up timer is set #502

Closed
brandonaut opened this issue Feb 9, 2021 · 3 comments · Fixed by #554
Closed

Visual confirmation that the Wake Up timer is set #502

brandonaut opened this issue Feb 9, 2021 · 3 comments · Fixed by #554
Assignees
Labels
always-fresh Issues that will never become stale enhancement New feature or request good first issue Good for newcomers priority/medium

Comments

@brandonaut
Copy link

Is your feature request related to a problem? Please describe.

When setting the Wake Up timer, I find it difficult to tell if the alarm is actually set or not. There's not a clear indication that it's enabled.

Describe the solution you'd like

I really like how the native Android clock handles this. When you set the alarm time, it immediately shows a toast notification with the remaining time until the alarm goes off: "Alarm set for 3 hours from now". This has the added benefit of giving a sanity check that you set the alarm time properly, and didn't accidentally switch the AM/PM or something.

@brandonaut brandonaut added the enhancement New feature or request label Feb 9, 2021
@ashutoshgngwr
Copy link
Member

@brandonaut I just pushed a release and didn't notice this issue. I'll definitely add this in the next release.

@ashutoshgngwr ashutoshgngwr added always-fresh Issues that will never become stale good first issue Good for newcomers priority/medium labels Feb 10, 2021
@robercoding
Copy link
Contributor

Do you mind if try to implement this solution? I'll add a UI test also 😄

@ashutoshgngwr
Copy link
Member

@robercoding Sure, go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
always-fresh Issues that will never become stale enhancement New feature or request good first issue Good for newcomers priority/medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants