Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Support calculating the TX hash of a transaction #4001

Closed
10gic opened this issue Aug 26, 2024 · 1 comment
Closed

[Feature Request]: Support calculating the TX hash of a transaction #4001

10gic opened this issue Aug 26, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@10gic
Copy link
Contributor

10gic commented Aug 26, 2024

TX hash is useful for tracking the status of a transaction on the blockchain. Sometimes, we want to know the TX hash before the transaction is broadcasted.

Currently, the TX hash is only available for a few blockchains in the SigningOutput object.

There are cases where the TX is not constructed by the wallet core; for example, the transaction might be constructed by a DApp. The DApp only requests the wallet to perform the signing, constructs the transaction itself, and then asks the wallet to broadcast it.

I think it's useful to have a common function to calculate the TX hash of a transaction.

@10gic 10gic added the enhancement New feature or request label Aug 26, 2024
@satoshiotomakan
Copy link
Collaborator

Hi @10gic, thank you for the issue! That definitely makes sense, I'll put this on the roadmap. However, I can't say it will be done soon as we're fully loaded right now. But I'll add TX hash for new blockchains for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants
@10gic @satoshiotomakan and others