Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework encrypted chunked extension #20

Closed
robin-nitrokey opened this issue Mar 15, 2024 · 1 comment · Fixed by #21
Closed

Rework encrypted chunked extension #20

robin-nitrokey opened this issue Mar 15, 2024 · 1 comment · Fixed by #21

Comments

@robin-nitrokey
Copy link
Member

robin-nitrokey commented Mar 15, 2024

Currently, the ChunkedExtension gains additional syscalls if the encrypted-chunked feature is enabled. This has the downside that enabling the feature in one crate can break another crate that does not have the feature enabled. I see two alternatives:

  1. Introduce an EncryptedChunkedExtension that is still optional in the backend. This would mean that runners could save some resources if they don’t need the encrypted calls.
  2. Remove the feature gate and always provide the encryption functions in ChunkedExtension. In practice, opcard requires encrypted-chunked, so it will always be enabled in the firmware and the use case for a separate extension is only theoritical.

I would go with (2). What do you prefer @sosthene-nitrokey?

@sosthene-nitrokey
Copy link
Collaborator

I would go with 2 also.

We could also put the implementation itself behind a feature-flag if we ever need to make it optional again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants