Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review numeric casts #70

Open
robin-nitrokey opened this issue Jul 18, 2024 · 0 comments
Open

Review numeric casts #70

robin-nitrokey opened this issue Jul 18, 2024 · 0 comments

Comments

@robin-nitrokey
Copy link
Member

This crate contains many numeric casts. Some of them can be problematic, at least if u32 does not fit in usize on the target platform.

We should therefore review these casts and probably enable the cast_lossless, cast_possible_truncation, cast_possible_wrap, cast_sign_loss lints. (Personally I’d like to enable as_conversions but we often need it for pointer conversions.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robin-nitrokey