Refactor sortByPriceAndNonce cache to.hex (#203)

Removed the ! in the conditional to improve readability. Cached the result of to.hex for subsequent calls.
trufflesuite · Oct 24, 2018 · 398125f · 398125f
1 parent 0139355
commit 398125f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 7 deletions.
diff --git a/lib/blockchain_double.js b/lib/blockchain_double.js
@@ -392,10 +392,11 @@ BlockchainDouble.prototype.sortByPriceAndNonce = function() {
   var sortedByNonce = {};
 
   self.pending_transactions.forEach((tx) => {
-    if (!sortedByNonce[to.hex(tx.from)]){
-      sortedByNonce[to.hex(tx.from)] = [tx];
+    const from = to.hex(tx.from);
+    if (sortedByNonce[from]){
+      sortedByNonce[from].push(tx);
     } else {
-      sortedByNonce[to.hex(tx.from)].push(tx);
+      sortedByNonce[from] = [tx];
     }
   });
 

diff --git a/npm-shrinkwrap.json b/npm-shrinkwrap.json