Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Slack Webhook Detector Validation #880

Closed
marshalltech81 opened this issue Oct 30, 2022 · 2 comments · Fixed by #932
Closed

[BUG] Slack Webhook Detector Validation #880

marshalltech81 opened this issue Oct 30, 2022 · 2 comments · Fixed by #932
Assignees
Labels

Comments

@marshalltech81
Copy link

marshalltech81 commented Oct 30, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

TruffleHog Version

v3.16.1

Trace Output

n/A

Expected Behavior

Slack Webhooks should be validated

Actual Behavior

Slack Webhooks are not validated

Steps to Reproduce

  1. Run Trufflehog against a repository that contains a valid Slack Webhook and it will not be validated

Environment

n/A

Additional Context

It appears as if the validator is looking for the presence of missing_text in the response back. Slack returns a 400 with no_text. Please see attached screenshot.

References

  • #0000
@marshalltech81
Copy link
Author

Screen Shot 2022-10-29 at 11 05 09 PM

@marshalltech81 marshalltech81 changed the title [BUG] Slack Webhook Detector [BUG] Slack Webhook Detector Validation Oct 30, 2022
@ahrav ahrav self-assigned this Nov 20, 2022
@ahrav ahrav linked a pull request Nov 20, 2022 that will close this issue
@ahrav
Copy link
Collaborator

ahrav commented Nov 20, 2022

Thanks again @marshalltech81 for raising this issue. it is greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants