Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initctl doesn’t complete restart when command is isssued from app to restart #280

Closed
hongkongkiwi opened this issue May 29, 2022 · 2 comments
Milestone

Comments

@hongkongkiwi
Copy link
Contributor

So I have an app which calls initctl restart to restart itself. Well actually I’m calling restart on the whole group, there’s many different apps in the names group.

But I’ve found that when the app dies it kills the child process of initctl.

The app only stops but doesn’t restart again. My theory is that initctl dies after sending the stop command and never gets to sending the start command.

I sort of expect that a restart command once sent is left Upto finit to handle so even if initctl is killed it should complete the restarting.

I’ve got a workaround for now but I wanted to report it as an issue.

@troglobit
Copy link
Owner

Yes, that's a current limitation, unfortunately. We had an implementation in Finit before, which caused other problems, so the restart (stop + start) functionality was moved to initctl. I don't think anyone expected restart on oneself as a use-case.

I'll see what we can come up with, likely fold it into the state machine redesign already planned.

@troglobit troglobit added this to the 4.4 milestone May 29, 2022
@troglobit
Copy link
Owner

There, should work better now. Also added a regression test for it so we don't stumble upon this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants