Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source URL with query string #24

Open
teohhanhui opened this issue Aug 18, 2016 · 0 comments
Open

Source URL with query string #24

teohhanhui opened this issue Aug 18, 2016 · 0 comments

Comments

@teohhanhui
Copy link
Contributor

e.g. https://avatars2.githubusercontent.com/u/548843?v=3&s=96

The query string is not passed on to the source, as the source url is not properly URL-encoded.

Fixing this would introduce a BC break. (We cannot just blindly perform URL decode, as we risk double decoding...) Should the requirement to URL encode be applied to all sources, or should it be configurable per source?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant