From 731c032f377f4e748f3d75119554c908f00f419a Mon Sep 17 00:00:00 2001 From: Piotr Findeisen Date: Tue, 18 Jan 2022 09:54:03 +0100 Subject: [PATCH] Abstain from overriding @BeforeClass init method There is no need for that, and thus it should be avoided, as it introduces unnecessary flow dependencies, or ordering of events. Regular `@BeforeClass` should be used instead. --- .../java/io/trino/testing/AbstractTestFailureRecovery.java | 4 +--- .../io/trino/testing/BaseDynamicPartitionPruningTest.java | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/testing/trino-testing/src/main/java/io/trino/testing/AbstractTestFailureRecovery.java b/testing/trino-testing/src/main/java/io/trino/testing/AbstractTestFailureRecovery.java index 9cc17d4192bf..30ab1db010f0 100644 --- a/testing/trino-testing/src/main/java/io/trino/testing/AbstractTestFailureRecovery.java +++ b/testing/trino-testing/src/main/java/io/trino/testing/AbstractTestFailureRecovery.java @@ -107,11 +107,9 @@ protected abstract QueryRunner createQueryRunner(List> requiredTpch throws Exception; @BeforeClass - @Override - public void init() + public void initTables() throws Exception { - super.init(); // setup partitioned fact table for dynamic partition pruning createPartitionedLineitemTable(PARTITIONED_LINEITEM, ImmutableList.of("orderkey", "partkey", "suppkey"), "suppkey"); } diff --git a/testing/trino-testing/src/main/java/io/trino/testing/BaseDynamicPartitionPruningTest.java b/testing/trino-testing/src/main/java/io/trino/testing/BaseDynamicPartitionPruningTest.java index ce71cf554714..eecd18b97a05 100644 --- a/testing/trino-testing/src/main/java/io/trino/testing/BaseDynamicPartitionPruningTest.java +++ b/testing/trino-testing/src/main/java/io/trino/testing/BaseDynamicPartitionPruningTest.java @@ -64,11 +64,9 @@ public abstract class BaseDynamicPartitionPruningTest "optimizer.rewrite-filtering-semi-join-to-inner-join", "false"); @BeforeClass - @Override - public void init() + public void initTables() throws Exception { - super.init(); // setup partitioned fact table for dynamic partition pruning createLineitemTable(PARTITIONED_LINEITEM, ImmutableList.of("orderkey", "partkey", "suppkey"), ImmutableList.of("suppkey")); }