Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NativeScript-vue support is broken in the NS-vue 2.0.0-alpha version #74

Closed
msaelices opened this issue Jul 5, 2018 · 3 comments · Fixed by #81
Closed

NativeScript-vue support is broken in the NS-vue 2.0.0-alpha version #74

msaelices opened this issue Jul 5, 2018 · 3 comments · Fixed by #81

Comments

@msaelices
Copy link

I guess the only change needed is changing the <native-pager> tag name to <NativePager> one here:

https://github.com/triniwiz/nativescript-pager/blob/master/src/vue/pager.js#L26

@msaelices
Copy link
Author

CC/ @rigor789

@msaelices msaelices changed the title NativeScript-vue support is broken in the NS-vue 2.0.0 version NativeScript-vue support is broken in the NS-vue 2.0.0-alpha version Jul 5, 2018
@rigor789
Copy link
Contributor

rigor789 commented Jul 6, 2018

Have you tried it? I think native-pager should still work, since vue can resolve it to NativePager

@msaelices
Copy link
Author

msaelices commented Jul 6, 2018

@rigor789 Yes I tried the app-with-pager.js app and there was an exception

@triniwiz triniwiz mentioned this issue Nov 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants