Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The event selectedIndexChanged doesn't work on v5.0.10 #36

Closed
ogrinishin opened this issue Dec 8, 2017 · 3 comments
Closed

The event selectedIndexChanged doesn't work on v5.0.10 #36

ogrinishin opened this issue Dec 8, 2017 · 3 comments

Comments

@ogrinishin
Copy link

It seems to me, that the line
pager.notify({ eventName: Pager.selectedIndexChangedEvent, object: pager, oldIndex: oldValue, newIndex: newValue });
after 60 line in file
node_modules\nativescript-pager\src\common.js
is lost.
Because without it the event selectedIndexChanged isn't triggered. Can you please fix it in your plugin?

@triniwiz
Copy link
Owner

triniwiz commented Dec 8, 2017

it's selectedIndexChange not selectedIndexChanged in {N} v3 the the events names moved from changed to change

@ogrinishin
Copy link
Author

ogrinishin commented Dec 8, 2017

@triniwiz
I tried to change but it is still broken, additionally there is not selectedIndexChange event in the node module,
look at the screen

@triniwiz
Copy link
Owner

triniwiz commented Dec 8, 2017

The following is how the event gets triggered ios event
android event or other android event check out why i removed selectedIndexChanged to use the default propertyName + Change from the new property modules i can probably add in for backwards compatibility

@triniwiz triniwiz closed this as completed Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants