Skip to content

Latest commit

 

History

History
49 lines (37 loc) · 2.47 KB

CONTRIBUTING.md

File metadata and controls

49 lines (37 loc) · 2.47 KB

How to contribute

I appreciate any and all help in developing the client -- patches welcome!

Reporting issues

Bugs, feature requests, and development-related questions should be directed to the GitHub issue tracker.

If reporting a bug, please try and provide as much context as possible such as your operating system, Go version, and anything else that might be relevant to the bug. Including (redacted) client logs with Debug enabled can help for parse or request errors.

For feature requests, please explain what you're trying to do, and how the requested feature would help you do that.

Submitting a patch

  1. It's generally best to start by opening a new issue describing the bug or feature you're intending to fix. Even if you think it's relatively minor, it's helpful to know what people are working on. Mention in the initial issue that you are planning to work on that bug or feature so that it can be assigned to you.

  2. Follow the normal process of forking the project, and setup a new branch to work in. It's important that each group of changes be done in separate branches in order to ensure that a pull request only includes the commits related to that bug or feature.

  3. Go makes it very simple to ensure properly formatted code, so always run go fmt on your code before committing it.

  4. Any significant changes should almost always be accompanied by tests. The project already has good test coverage, so look at some of the existing tests if you're unsure how to go about it. gocov and gocov-html are invaluable tools for seeing which parts of your code aren't being exercised by your tests.

  5. Please run:`

    • go test github.com/trinchan/sysdig-go/...
    • go vet github.com/trinchan/sysdig-go/...

  6. Do your best to have well-formed commit messages for each change. This provides consistency throughout the project, and ensures that commit messages are formatted properly by various git tools.

  7. Finally, push the commits to your fork and submit a pull request. NOTE: Please do not use force-push on PRs in this repo, as it makes it more difficult for reviewers to see what has changed since the last code review.