Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix allowed symbols in commands #4

Open
alerque opened this issue Dec 26, 2019 · 1 comment
Open

Fix allowed symbols in commands #4

alerque opened this issue Dec 26, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@alerque
Copy link
Collaborator

alerque commented Dec 26, 2019

I started matching ex commands with the list of predefined ones (not including default aliases). These names ale all alpha letters, a couple than have numbers, and few more that have underscores. I'm currently allowing that character range for user defined commands and aliases, but I see we have at least one exception to account for: exclaim is aliased to !.

That opens the can of worms that I'm not sure which symbols should be allowed in command names. What else might be allowed? Dashes? Other symbols? What should I account for?

@bovine3dom perhaps you can point me in the right direction...

@alerque alerque added the bug Something isn't working label Dec 26, 2019
@bovine3dom
Copy link
Member

I only just saw this, sorry.

We have one reserved command name: you can't call any configuration key 🕷🕷INHERITS🕷🕷, so you can't have exactly that as an ex-command. Everything else except spaces is allowed.

Why do you have to account for what might or might not be allowed in a command name?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants