Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open new private window command #317

Closed
omar-selo opened this issue Feb 27, 2018 · 10 comments
Closed

Open new private window command #317

omar-selo opened this issue Feb 27, 2018 · 10 comments

Comments

@omar-selo
Copy link

I wonder if there is an open private window command similar to that to winopen. If not would it be possible to add one? Also using hinting to open a new private window would be nice too.

@bovine3dom
Copy link
Member

winopen -private, which I now realise is undocumented. There isn't any hint mode for it, yet, but I don't believe anyone else has asked.

@IsaacKhor
Copy link
Contributor

IsaacKhor commented Feb 28, 2018

Should we add a hint -P (private) option, or something similar?

@gsbabil
Copy link
Contributor

gsbabil commented Mar 2, 2018

@bovine3dom

winopen -private, which I now realise is undocumented.

Thanks for pointing out the winopen -private option. Is there a
default keyboard shortcut assigned to it?

If not, may be we should assign one as default. Is patching
config.ts still the preferred way to adding default shortcuts?

I'm still using the tri.config.get("nmaps") to review the current
bindings. Is there any other way to see them?

Thank you.

@bovine3dom @IsaacKhor

Should we add a hint -P (private) option, or something similar?

I think this could be very useful given that the hinted link would
open in the private window.

On the same train of thoughts, it might also be useful to have a
hint-mode to open targets in different Firefox context i.e. Work,
Personal etc.

Thank you.

P.S.

Going through the existing issues, it seems that #283 might be
along the same line as my request above.

@bovine3dom
Copy link
Member

Thanks for pointing out the winopen -private option. Is there a
default keyboard shortcut assigned to it?

If not, may be we should assign one as default. Is patching
config.ts still the preferred way to adding default shortcuts?

No, but I am not sure we need a bind. We don't have many keys left. Which keys did you have in mind? Yes, config.ts is still the home of the default settings.

I'm still using the tri.config.get("nmaps") to review the current
bindings. Is there any other way to see them?

:get nmaps now works in a pinch by dumping the config in the command line, but the debugging approach has a much prettier JSON formatter.

@gsbabil
Copy link
Contributor

gsbabil commented Mar 3, 2018

@bovine3dom

Thanks for the prompt reply.

No, but I am not sure we need a bind. We don't have many keys
left.

I understand. Thanks.

Which keys did you have in mind? Yes, config.ts is still
the home of the default settings.

I'm currently using ,w to open a new window, and ,wp to open a
new private window, where , is the preferred leader key.

On that note, do we have any setting to set the leader or
localleader keys in Tridactyl. In Vim, this is usually achieved by
the following:

  let mapleader = ","
  let maplocalleader = ","

  nnoremap <localleader>l :command-name <cr>

:get nmaps now works in a pinch by dumping the config in the
command line, but the debugging approach has a much prettier JSON
formatter.

Thanks for the :get nmaps hint and it works you mentioned.
However, I agree with you that the tri.config.get("nmaps")
approach indeed produces much more readable output.

Thank you.

@IsaacKhor
Copy link
Contributor

Can you close this issue if you have no more questions? It helps to reduce the clutter.

@gsbabil
Copy link
Contributor

gsbabil commented Mar 11, 2018

@IsaacKhor, @bovine3dom

Can you close this issue if you have no more questions? It helps
to reduce the clutter.

Thanks. I have no more questions. But I don't seem to have
permission to close the issue.

May be @Bazalia (opened the issue) would have to do it.

Thank you.

@omar-selo
Copy link
Author

Just one last question regarding the hinting. Will the open in private window be added?

@bovine3dom
Copy link
Member

@Bazalia I've added it to the hintprivate branch but can't test it right now.

@bovine3dom
Copy link
Member

Should we add a hint -P (private) option, or something similar?

@Bazalia, @IsaacKhor: added as hint -w and hint -wp in c042fd1 and bound to ;w and ;W

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants