Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tlsOptions by upgrading ldapjs #12

Merged
merged 2 commits into from
Aug 26, 2013

Conversation

vesse
Copy link
Contributor

@vesse vesse commented Aug 15, 2013

I need to use ldaps:// protocol to connect to the LDAP server in our organization. In order for the connection to succeed I need to be able to pass the CA certificate to tls module.

Latest ldapjs Client supports passing the tlsOptions to the tls module. This pull request upgrades ldapjs and adds tlsOptions (as well as timeout and connectTimeout) options to LdapAuth constructor.

vesse and others added 2 commits August 15, 2013 14:07
Uprade ldapjs and add more options that can be passed to ldapjs client,
most notably the tlsOptions which enables many features needed in order
to be able to use ldaps with some LDAP servers.
New options, changed the line numbers to include those as well.
trentm added a commit that referenced this pull request Aug 26, 2013
Enable tlsOptions, timeout and connectTimeout options
@trentm trentm merged commit 32c283a into trentm:master Aug 26, 2013
@trentm
Copy link
Owner

trentm commented Aug 26, 2013

Thanks! Sorry for the delay. Merged and released to npm as version 2.2.4.

@vesse
Copy link
Contributor Author

vesse commented Aug 26, 2013

Thanks. I had a really urgent need so I had to fork and release, and while at it I also added fixes for issues #10, #8, #3, and #2. If you're interested these are in master of my fork. My intention is not to maintain the fork if the changes are merged.

@cstephe
Copy link

cstephe commented Dec 10, 2013

Whats the fix for #2

@vesse vesse deleted the enable-tls-options branch December 10, 2013 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants