Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substring search across repositories #7596

Closed
dsgibbons opened this issue Mar 25, 2024 · 3 comments · Fixed by #8417
Closed

Substring search across repositories #7596

dsgibbons opened this issue Mar 25, 2024 · 3 comments · Fixed by #8417

Comments

@dsgibbons
Copy link

dsgibbons commented Mar 25, 2024

The search bar in the UI currently searches by exact string matches from the beginning of the repository name. Fuzzy matching would make it easier to find repositories through the UI. This is especially useful when we have hundreds of repositories.

image

Resource:
https://staging.us-east-1.lakefscloud.ninja/api/v1/repositories?prefix=nada&after=&amount=100

@hoac4
Copy link

hoac4 commented Dec 3, 2024

The following search fields would also benefit from the ability to fuzzy search:

  • Administration > Groups > [Select Group] > Group Memberships > Add Members > Find User
  • Administration > Groups > [Select Group] > Attached Policies > Attach Policy > Find Policies

@nadavsteindler
Copy link
Contributor

nadavsteindler commented Dec 18, 2024

I'd like to sanity test this a bit in staging...
creating a new org, deploying the docker, creating many repos via script...
https://github.com/treeverse/lakeFS/actions/runs/12393706843/job/34595531361
https://treeverse-supreme-kingfish-suwr6m.us-east-1.lakefscloud.ninja/repositories

I created 1000 repos with groups of similar names
Results: it's fast- search is sub-second. Not noticeable slower than prefix search

@arielshaqed
Copy link
Contributor

To be explicit: We implemented substring search. We do not have current plans to perform a "fuzzy" search.

@nadavsteindler nadavsteindler changed the title Fuzzy search across repositories Substring search across repositories Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants