Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release for 0.16.x series? #98

Closed
claytonrcarter opened this issue Aug 11, 2021 · 2 comments
Closed

New release for 0.16.x series? #98

claytonrcarter opened this issue Aug 11, 2021 · 2 comments

Comments

@claytonrcarter
Copy link

I know that this sort of backwards, but is there any chance we could beg for a release that is built against tree-sitter 0.16 (or any version w/ ABI version <=12)? I've been working on updating Atom's PHP grammar with tree-sitter support, but Atom currently only supports ABI <=12 (I think), and that limits me to using 0.16.2 of tree-sitter-php, which of course lacks all of the goodies that @cfroystad has been working on recently for #58.

There is a blocked PR to update Atom to tree-sitter 0.19, but it looks like it's gone a bit stale. While we wait for that, though, having a BC release against tree-sitter 0.16 would give me the tools to fill in much more of that grammar w/ arrow functions, nullsafe, union types, etc, making it more likely it could be considered for release.

For the record, on current master I was able to successfully downgrade tree-sitter-cli, regenerate and pass all tests:

$ npm i tree-sitter-cli@0.16

$ ./node_modules/.bin/tree-sitter generate

$ grep 'LANGUAGE_VERSION ' src/parser.c
#define LANGUAGE_VERSION 11

$ ./node_modules/.bin/tree-sitter test
# ... all tests passed

Thanks for at least considering this!

@cfroystad
Copy link
Collaborator

@maxbrunsfeld I guess you're the only one who can answer this one 🙂

As a side note: If you could either point me to relevant documentation or describe the current release process, I'd like to look into automating building and pushing updated releases of tree-sitter-php whenever tagged

@claytonrcarter
Copy link
Author

With the sunset of Atom, this is no longer an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants