Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faraday 2.x and 1.x cross support #94

Merged
merged 3 commits into from
Feb 22, 2023
Merged

Faraday 2.x and 1.x cross support #94

merged 3 commits into from
Feb 22, 2023

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Feb 22, 2023 •
edited
Loading

Purpose

Added Faraday 2.x support while keeping Faraday 1.x support.

Overview

  • Middleware usage is rewritten in a way compatible with both Faraday 1.x and 2.x.
  • Added Faraday version to CI matrix.

Note

You can see that Faraday 2.7.4 and 1.10.3 are used in each CI jobs.

https://github.com/treasure-data/trino-client-ruby/actions/runs/4239442131/jobs/7367502926
image

https://github.com/treasure-data/trino-client-ruby/actions/runs/4239441863/jobs/7367502185
image

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@github-actions github-actions bot added the doc label Feb 22, 2023
@exoego exoego marked this pull request as ready for review February 22, 2023 04:37
@exoego exoego requested a review from a team as a code owner February 22, 2023 04:37
@exoego exoego mentioned this pull request Feb 22, 2023
Merged
4 tasks
@exoego exoego changed the title Faraday 2.x support Faraday 2.x support (1.x support is maintained) Feb 22, 2023
@exoego exoego changed the title Faraday 2.x support (1.x support is maintained) Faraday 2.x and 1.x cross support Feb 22, 2023
yuokada
yuokada approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@yuokada yuokada left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM ✅

@exoego exoego merged commit 401639e into master Feb 22, 2023
@exoego exoego deleted the faraday-2-support branch February 22, 2023 05:04
@yuokada yuokada removed the doc label Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuokada yuokada yuokada approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@exoego @yuokada