Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alias gem 'trino-client-ruby' #74

Merged
merged 2 commits into from
Oct 22, 2021
Merged

Add alias gem 'trino-client-ruby' #74

merged 2 commits into from
Oct 22, 2021

Conversation

takezoe
Copy link
Member

@takezoe takezoe commented Oct 17, 2021 •
edited
Loading

Purpose

To reserve trino-client-ruby gem that has the same name as GitHub repository

Overview

Add trino-client-ruby gem as an alias of trino-client gem.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@takezoe takezoe requested a review from a team as a code owner October 17, 2021 04:01
miniway
miniway approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@miniway miniway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. Also it would be nice if we have a small script to publish the same gem at the same time

@takezoe
Copy link
Member Author

takezoe commented Oct 22, 2021

Thank you! I added a script and published trino-client-ruby-1.0.0.gem as an alias to trino-client 1.0.0.

@takezoe takezoe merged commit 6829f5b into treasure-data:master Oct 22, 2021
@takezoe takezoe deleted the alias-gem branch October 22, 2021 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniway miniway miniway approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@takezoe @miniway @exoego