Add derived vs. non-derived benchmark #96
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been meaning to add a benchmark comparing derived and non-derived codecs for a while, and this question from @adelbertc was a good reminder.
The non-derived decoders and encoders are intended to be idiomatic, and one of the interesting things the benchmarks show is that
Json.obj
(used in the non-derived encoder but not the derived one) needs some work—the derived encoder is actually faster than the hand-written one. The throughput of the derived decoder is about 3% lower than the non-derived one, which is within the margin of error.The derived decoders and encoders also look pretty good in terms of allocations:
So performance probably isn't usually a good reason to avoid generic derivation here.