Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tagging of docker images in the erGW CI builds #300

Closed
vkatsuba opened this issue Jan 26, 2021 · 1 comment · Fixed by #304 or #333
Closed

Fix tagging of docker images in the erGW CI builds #300

vkatsuba opened this issue Jan 26, 2021 · 1 comment · Fixed by #304 or #333
Labels
improvement 💡 Improvement

Comments

@vkatsuba
Copy link
Contributor

vkatsuba commented Jan 26, 2021 •
edited
Loading

erGW version

2.8.4

Description

The CI builds should properly tag erGW docker images.

Current behavior

Currently the erGW build scripts do not tag docker images properly when building a tag. It tags them with branch_tag format (e.g. master_2.8.4).

Expected behavior

The docker images built by CI triggered by tagging in the repository makes a docker image available with only the tag (e.g. 2.8.4)
@vkatsuba vkatsuba added feature 🚀 Feature Request improvement 💡 Improvement and removed feature 🚀 Feature Request labels Jan 26, 2021
@vkatsuba
Copy link
Contributor Author

The main staff was implemented in #307, however still need fix issue with v prefix of tag name in docker images.

This was linked to pull requests Mar 2, 2021
multiarch build support on Travis and GitLab-CI #304
Merged
Remove prefix v from image tag #333
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement 💡 Improvement
Projects
None yet
Milestone
No milestone
1 participant
@vkatsuba