Typescript error caused by wrong import in @uppy/provider-views

[francisbourquestudyo]

Initial checklist

• I understand this is a bug report and questions should be posted in the Community Forum
• I searched issues and couldn’t find anything (or linked relevant results below)

Link to runnable example

No response

Steps to reproduce

This new import in the @uppy/provider-views package introduces Typescript compilation errors. It should do an import from lib and not src. We are not importing the package explicitly, but it's probably a dependency for the dashboard or the React package.

The only solution for now is to have an override in our package.json setting the version to 4.3.0.

We already filled an issue a couple weeks ago for a similar issue in the @uppy/onedrive package.

Expected behavior

Project should build without any errors.

Actual behavior

Project builds with errors.

[Xhale1]

I'm seeing a number of TypeScript errors as well when using the latest version of uppy. Mine seem to originate from Uppy core though I haven't dug too deep.

[Murderlon]

Sorry this keeps happening because our editors auto-import something incorrectly 🙄

[joshuajung]

When importing Uppy Core into my TypeScript project via import Uppy from "@uppy/core", I am also seeing these errors:

 ERROR(TypeScript)  'err' is of type 'unknown'.
 FILE  /myrepo/node_modules/@uppy/core/src/Uppy.ts:902:14

    900 |       this.#restricter.validateSingleFile(file)
    901 |     } catch (err) {
  > 902 |       return err.message
        |              ^^^
    903 |     }
    904 |     return null
    905 |   }

 ERROR(TypeScript)  'err' is of type 'unknown'.
 FILE  /myrepo/node_modules/@uppy/core/src/Uppy.ts:914:14

    912 |       this.#restricter.validateAggregateRestrictions(existingFiles, files)
    913 |     } catch (err) {
  > 914 |       return err.message
        |              ^^^
    915 |     }
    916 |     return null
    917 |   }

May this be related to this issue, or a separate topic?

[Murderlon]

Can you create a reproducible example in a new issue? Here are some links:

• Uppy Drag & Drop
• Uppy Dashboard
• Uppy React
• Uppy Svelte
• Uppy Vue

[joshuajung]

I have created a reproducible example at https://stackblitz.com/edit/vitejs-vite-twyc9zzx.

It is based on Uppy React, just upgraded @uppy/core to 4.4.0 and @uppy/dashboard to 4.3.0 (the latter seems to be the culprit actually, sorry for being imprecise in my first message).

To see a bunch of TS errors for the ./src directory, including the two I mentioned above, simply stop Vite and run tsc in the terminal.

[Murderlon]

I think it may be related after all. Putting out a new release now and testing your example afterwards.

[Murderlon]

Works as expected now: https://stackblitz.com/edit/vitejs-vite-4vsnw5eg?file=package.json,src%2FApp.tsx

[joshuajung]

Awesome, the issues are gone for me locally as well. Thanks a lot for the super quick turnaround.