Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STS client side signing with accelerated endpoint #4822

Open
2 tasks done
mifi opened this issue Dec 12, 2023 · 3 comments
Open
2 tasks done

STS client side signing with accelerated endpoint #4822

mifi opened this issue Dec 12, 2023 · 3 comments
Labels
AWS S3 Plugin that handles uploads to Amazon AWS S3 Feature

Comments

@mifi
Copy link
Contributor

mifi commented Dec 12, 2023

Initial checklist

  • I understand this is a feature request and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Problem

#4809 (comment)

Solution

allow client side signing also using accelerated endpoint also with STS

Alternatives

just say that we don't support that

@movy
Copy link

movy commented Dec 13, 2023

Thanks for this issue. I was mulling over the meaning behind getTemporarySecurityCredentials as it's not instantly obvious from the docs for those who are new to S3/STS business, now thanks to this and prev issue, its meaning is clear now.

As a temporary fix, I've set getTemporarySecurityCredentials: false in our uppy setup and everything works as expected now.

Another issue that was fixed along the way was uploads stalling in Chrome on MacOS after first chunk was sent, note the second (pending) request, it hangs forever:

image

(hangs only with getTemporarySecurityCredentials: true).

No issues in Safari or Firefox. I see no connection here, maybe we can investigate further later.

I also had to add POST to allowed methods in S3 CORS configuration, as it was not listed on docs page (https://uppy.io/docs/aws-s3-multipart/#setting-up-your-s3-bucket), but without this my browser could not start uploads due to a CORS error.

Either way, thanks for your help with this!

@Murderlon
Copy link
Member

@aduh95 seems like we are sending a duplicate request in s3-multipart which never resolves.

@stephenhuh
Copy link

any updates on this one? while presigning can work, it just introduces too much network overhead (and cost)

@Murderlon Murderlon added the AWS S3 Plugin that handles uploads to Amazon AWS S3 label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AWS S3 Plugin that handles uploads to Amazon AWS S3 Feature
Projects
None yet
Development

No branches or pull requests

4 participants