Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoke test uppy.io on CI deploy #4226

Open
2 tasks done
mifi opened this issue Nov 21, 2022 · 2 comments
Open
2 tasks done

Smoke test uppy.io on CI deploy #4226

mifi opened this issue Nov 21, 2022 · 2 comments
Labels

Comments

@mifi
Copy link
Contributor

mifi commented Nov 21, 2022

Initial checklist

  • I understand this is a feature request and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Problem

We have sometimes been surprised that uppy.io has been broken without us knowing

Solution

Create a simple smoke test (browser test?) of for example uploading a file from an URL - which will hit the multiple Companion instances.

Because uppy.io now runs with two instances of companion behind a load balancer, this will make sure that companion works properly with multiple instances (which is hard to forget to check when developing locally)

Alternatives

Make a functional test as part of the test suite, but then we need to do a lot of extra configuring and setting up a local load balancer etc, so a smoke test could be a shortcut. See also #3538

@Murderlon
Copy link
Member

I think we can close this as we're close to a new website in a different repository, which AFAIK will be rebuild on new releases, which are far more likely to be stable. Alternatively, we transfer this issue to that repo and create an e2e test.

@arturi
Copy link
Contributor

arturi commented Nov 22, 2022

I am for this independent test that just tests Uppy.io and annoyingly emails me if it fails to upload via URL. I can look into implementing this.

@arturi arturi removed the Triage label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants