exif-js causing strict mode issues

[mskelton]

exif-js is having trouble when generating thumbnails for certain images. I believe the issue might be due to strict mode as it always happens in our implementation of Uppy but not any of the example apps in this repo. The exact error we are getting has been reported twice on the exif-js repo and they seem to point to strict mode issues.

• n is not defined  exif-js/exif-js#214
• n is undefied exif-js/exif-js#220
• add var in for loop exif-js/exif-js#50
• error: n is not defined (Has possible fix solution attached) kartoteket/vue-image-upload-resize#15 (comment)

exif-js is unmaintained and should probably be replaced with something that is maintained like ExifReader. The last release was in October of 2017. See this commit (mattiasw/ExifReader@09cda65) for more details on ExifReader and how it works to replace exif-js.

Thanks!

[MikeKovarik]

Hello. I would like to chime in with my library exifr.

I started writing it because of the state of exif-js as well as my needs to be able to process hundreds of photos (i.e. gigabytes of photos) as fast as possible. Since then I kept adding more features, like thumbnail extraction, ICC support, TIFF and HEIC file formats, filtering (so parsing stops as soon as all wanted tags are found) and more.

I would love exifr to be the replacement library and I would happily do the replacement PR myself as well as implementing or fixing whatever is necessary for it to work.

Thank you