Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs when spawning a new music #1309

Open
mugg91 opened this issue Jul 6, 2022 · 1 comment · May be fixed by #2272
Open

Bugs when spawning a new music #1309

mugg91 opened this issue Jul 6, 2022 · 1 comment · May be fixed by #2272
Labels
bug An *objective* unintended feature/mechanic that should be fixed

Comments

@mugg91
Copy link
Contributor

mugg91 commented Jul 6, 2022

Description

When spawning a new music via chat command there are problems.
These problems happen in offline and online and are not fixed by rejoining a server.

  1. Spawning a challenge_music will cause music to play for 2 seconds and then stops suddenly, repeatedly.
    This happens both offline and online and isn't fixed by rejoining the server. The music stays bugged forever.
  2. Spawning a ctf_music on top of pre-existing other music will cause the ctf_music to play on top of it. "KAGWorld1-14outro" will be used even though the match timer is running.
    This happens only in offline.
    In online, war_music, music and ctf_music will correctly replace each other.
  3. You would think tdm_music would work but it is named simply "music".

Tested in offline and online Sandbox. Other game modes may differ.

Reproduction

Go to offline Sandbox.
!ctf_music
Notice two musics playing on top of each other.


Go to online Sandbox EU server or offline Sandbox.
!challenge_music
Notice music getting bugged.


Go to online Sandbox EU server or offline Sandbox.
!tdm_music
Notice chat saying it doesn't exist.

Expected Behavior

Spawning a ctf_music should behave the same in offline and online, correctly replacing the existing music and not playing the outro when the match timer is still running.

Spawning a challenge_music should not wreck the music but replace the existing music and keep playing as normal.

TDMMusic should be configured as "tdm_music" instead of "music" for consistency reasons.

@eps0003 eps0003 added the bug An *objective* unintended feature/mechanic that should be fixed label Jul 6, 2022
@mugg91
Copy link
Contributor Author

mugg91 commented Jul 6, 2022

Instead of allowing spawning musics on top of each other it could be a possible solution to "not allow it":

  • Don't spawn the music if there is already one playing, or
  • put all types of musics on the blacklist in chat commands.

@mugg91 mugg91 linked a pull request Dec 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An *objective* unintended feature/mechanic that should be fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants