Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Increase/decrease speed #47

Closed
danrobi11 opened this issue Feb 23, 2022 · 13 comments
Closed

Feature Request: Increase/decrease speed #47

danrobi11 opened this issue Feb 23, 2022 · 13 comments
Assignees
Labels
enhancement New feature or request

Comments

@danrobi11
Copy link

Unless there's already an option and I havent seen it?

@tramhao
Copy link
Owner

tramhao commented Feb 24, 2022

There is no function for this but I saw it in several apps especailly for books. I'll add it to the plan. Thanks.

@tramhao tramhao self-assigned this Apr 6, 2022
@tramhao tramhao added the enhancement New feature or request label Apr 6, 2022
@tramhao
Copy link
Owner

tramhao commented Apr 25, 2022

please kindly check out 4c0c133. I tested symphonia backend with mp3 files and it works. Thanks.

@danrobi11
Copy link
Author

@tramhao Im not a dev, it doesnt mean much to me. Sry :/

I could always compile it. Im not sure which branch tho. Good to know it works on your end. Very nice 👍

@tramhao
Copy link
Owner

tramhao commented Apr 26, 2022

The dev branch is ok to checkout. And if it's ok, I'll include it in next release.

@tramhao
Copy link
Owner

tramhao commented Apr 26, 2022

After you git clone dev branch, you could use git checkout 4c0c133 to get the right commit. Thanks.

@danrobi11
Copy link
Author

danrobi11 commented Apr 26, 2022

Sry, something does not let me compile. We can call it here since it works for you.

$ make
cargo fmt --all
error: no such subcommand: `fmt`

	Did you mean `fix`?
make: *** [Makefile:6: fmt] Error 101

@Serial-ATA
Copy link
Contributor

Serial-ATA commented Apr 27, 2022

@danrobi11 You need to install rustfmt: rustup component add rustfmt (If you're using rustup) Actually, all you need to do is make release

@tramhao The instructions in the README say that you need to run make to build from source, but that's not the case:

default: fmt

default should be make release shouldn't it?

@danrobi11
Copy link
Author

danrobi11 commented Apr 27, 2022

Doesnt work with make release

$ make release
cargo build --release
error: failed to parse manifest at `/home/danrobi/termusic/Cargo.toml`

Caused by:
  failed to parse the `edition` key

Caused by:
  this version of Cargo is older than the `2021` edition, and only supports `2015` and `2018` editions.
make: *** [Makefile:14: release] Error 101`

I've tried installing rustup and rustfmt, im on debian based distro and thats what I get:

Error: rustup not found
Error: rustfmt not found

@tramhao
Copy link
Owner

tramhao commented Apr 27, 2022

Seems the rust toolchain in your system is old. Did you install from repo before? If so, don't worry, I'll include this feature in new version and hope you can get the update from your repo.

@danrobi11
Copy link
Author

Did you install from repo before?

Yep must be. Tbh, I dont recall installing it. Must be long time ago.

@Serial-ATA
Copy link
Contributor

Just to let you know, rust 2021 was released in 1.56.0. Looks like Debian stable is still on 1.48.0 (https://packages.qa.debian.org/r/rustc.html).

@danrobi11
Copy link
Author

danrobi11 commented Apr 28, 2022

@Serial-ATA

Looks like Debian stable is still on 1.48.0

Yep. Thank's for the link. Now that I know the package is named rustc:

Package: rustc
Version: 1.48.0+dfsg1-2
State: installed
Automatically installed: yes
Provided by: rustc-mozilla (1.51.0+dfsg1-1~deb11u1)

While we're at it. I've manually installed cargo, here's the info:

Package: cargo
Version: 0.47.0-3+b1
State: installed
Automatically installed: no

@danrobi11
Copy link
Author

Running the new v0.6.14 here. Increase/decrease speed working perfectly. Awesome 👍 Thank you much! @tramhao

Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants