From 95f36aa7e92c595c60042f8a57ff7ccc9407003e Mon Sep 17 00:00:00 2001 From: shadowhunt22 <155584978+shadowhunt22@users.noreply.github.com> Date: Thu, 9 May 2024 17:31:00 -0600 Subject: [PATCH] - Changed how the CustomLayerFeatureRenderer was added to the PlayerRenderer. Formally, this was done by injecting into Minecraft's PlayerRenderer#setModelProperties. There was a concern that "Somehow [injecting into the constructor to add the CustomLayerFeatureRenderer] in 1.16.5 is a bit unpredictable, [and that] only late adding layer works well," but my testing has shown there are no prevailing issues. --- .../skinlayers/mixin/PlayerRendererMixin.java | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/src/main/java/dev/tr7zw/skinlayers/mixin/PlayerRendererMixin.java b/src/main/java/dev/tr7zw/skinlayers/mixin/PlayerRendererMixin.java index 017c1c9..b8a51a2 100644 --- a/src/main/java/dev/tr7zw/skinlayers/mixin/PlayerRendererMixin.java +++ b/src/main/java/dev/tr7zw/skinlayers/mixin/PlayerRendererMixin.java @@ -51,21 +51,14 @@ public PlayerRendererMixin(Context context, PlayerModel en //#endif // spotless:on - private boolean loaded = false; - -// Somehow doing this in 1.16.5 is a bit unpredictable, only late adding layer works well. Not sure why -// @Inject(method = "*", at = @At("RETURN")) -// public void onCreate(CallbackInfo info) { -// this.addLayer(new CustomLayerFeatureRenderer(this)); -// } + @Inject(method = "", at = @At("RETURN")) + public void onCreate(CallbackInfo info) { + this.addLayer(new CustomLayerFeatureRenderer(this)); + } @SuppressWarnings("resource") @Inject(method = "setModelProperties", at = @At("RETURN")) public void setModelProperties(AbstractClientPlayer abstractClientPlayer, CallbackInfo info) { - if (!loaded) { - this.addLayer(new CustomLayerFeatureRenderer(this)); - loaded = true; - } if (Minecraft.getInstance().player == null || Minecraft.getInstance().player .distanceToSqr(abstractClientPlayer) > SkinLayersModBase.config.renderDistanceLOD * SkinLayersModBase.config.renderDistanceLOD) {