Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use py.path._gethomedir in ci context #24

Closed
pytoxbot opened this issue Sep 17, 2016 · 3 comments
Closed

don't use py.path._gethomedir in ci context #24

pytoxbot opened this issue Sep 17, 2016 · 3 comments
Labels
needs:discussion It's not quite clear if and how this should be done

Comments

@pytoxbot
Copy link

ci servers that run on win32 don't have a assigned homedir in the env

it makes sense to avoid using it there or generally making the substitution lazily calculated

@obestwalter
Copy link
Member

@RonnyPfannschmidt I am pretty sure that has been solved on one or other way in the meantime and can be closed. Correct?

@RonnyPfannschmidt
Copy link

no idea, please verify, its likely its not fixed

@obestwalter obestwalter added the needs:discussion It's not quite clear if and how this should be done label Dec 22, 2016
@obestwalter
Copy link
Member

This was fixed by simply catching any exception that might occur fetching the homedir ...

tox/tox/config.py

Lines 680 to 684 in e8891a5

def get_homedir():
try:
return py.path.local._gethomedir()
except Exception:
return None

@tox-dev tox-dev locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs:discussion It's not quite clear if and how this should be done
Projects
None yet
Development

No branches or pull requests

3 participants