Allow both pre- and post- PEP 610 outputs in test_venv_special_chars_issue252 #1594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hroncok
requested review from
asottile,
gaborbernat and
obestwalter
as code owners
…issue252 pip 20.1+ supports PEP 610 https://www.python.org/dev/peps/pep-0610/ Hence the output is changed a bit. This was acknowledged in 553d6f2. Here we allow to run the tests with pip 19.3.x again by relaxing the regex to match both the old and the new format.
gaborbernat
approved these changes
Jun 2, 2020
|
Thanks. |
|
Do you need a release @hroncok? |
|
No, I've backported this. Thanks. |
ssbarnea
pushed a commit
to ssbarnea/tox
that referenced
this pull request
Apr 19, 2021
…issue252 (tox-dev#1594) pip 20.1+ supports PEP 610 https://www.python.org/dev/peps/pep-0610/ Hence the output is changed a bit. This was acknowledged in 553d6f2. Here we allow to run the tests with pip 19.3.x again by relaxing the regex to match both the old and the new format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pip 20.1+ supports PEP 610 https://www.python.org/dev/peps/pep-0610/
Hence the output is changed a bit.
This was acknowledged in 553d6f2.
Here we allow to run the tests with pip 19.3.x again
by relaxing the regex to match both the old and the new format.
Thanks for contributing a pull request!
If you are contributing for the first time or provide a trivial fix don't worry too
much about the checklist - we will help you get started.
Contribution checklist:
(also see CONTRIBUTING.rst for details)
updated/extended the documentation(trivial change)in message body (added a commit link)
<issue number>.<type>.rstfor example (588.bugfix.rst)<type>is must be one ofbugfix,feature,deprecation,breaking,doc,misc<your username>"superuser."CONTRIBUTORS(already there)