use latest version of importlib_metadata

[kammala]

Since November 30 importlib_metadata uses semver and has latest version 1.1.0.

If you use twine or pytest(which do not pin upper bound of importlib_metadata dependency) and tox in the same virtualenv and check for package integrity with pip check, you can easily run into the trouble that python installs importlib_metadata incompatible with tox.

Thanks for contributing a pull request!

If you are contributing for the first time or provide a trivial fix don't worry too
much about the checklist - we will help you get started.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

• wrote descriptive pull request text
• added/updated test(s)
• updated/extended the documentation
• added relevant issue keyword
  in message body
• added news fragment in changelog folder
  • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
  • <type> is must be one of bugfix, feature, deprecation,breaking, doc, misc
  • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
  • "sign" fragment with "by :user:<your username>"
  • please use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files - by :user:superuser."
  • also see examples
• added yourself to CONTRIBUTORS (preserving alphabetical order)

[gaborbernat]

[RonnyPfannschmidt]

@kammala thanks as well, i literally ran into this via devpi and its just great to come in and see something fixed right at that moment

@gaborbernat got an eta for a release?

[gaborbernat]

will need to fix the first master on which I have no ETA 🤔 if anyone could assist 👍

[gaborbernat]

Released as 3.14.2 - see https://tox.readthedocs.io/en/latest/changelog.html#v3-14-2-2019-12-02

Changelog history — tox 3.14.2.dev9 documentation

[chyzzqo2]

This pin seems too aggressive, why do we need >= 1.1.0 instead of > 0.12

[gaborbernat]

Feels alright to me, why would this cause an issue? It's our runtime dependency.

[asottile]

I could understand the issue, when trying to install tox alongside something else you'll potentially get conflicts

[kammala]

Personally I don't feel confident allowing multiple major versions to be installed — in this case we have to run tests against every major version separately.

Though in this case there were no major updates, only versioning schema was changed.

Also, because pip does not have proper dependency resolver, most likely in case of versions conflict we will have to pin version of importlib_metadata on higher level. One could pin tox there as well and create PR to conflicting package with update of importlib_metadata.

Let's see if we spot any incompatibility, we could always extend range of supported versions.

[gaborbernat]

That's why I was suggesting using pipx 👍 which sidesteps all your issues mentioned.