Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong succeeded message after KeyboardInterrupt #1453

Closed
schlamar opened this issue Nov 11, 2019 · 7 comments · Fixed by #1725
Closed

Wrong succeeded message after KeyboardInterrupt #1453

schlamar opened this issue Nov 11, 2019 · 7 comments · Fixed by #1725
Labels
bug:normal affects many people or has quite an impact

Comments

@schlamar
Copy link
Contributor

When hitting Ctrl+C while tox installs the package, this KeyboardInterrupt results in a wrong succeeded message.

There is a related fix by @asottile in #1257.

>tox
GLOB sdist-make: D:\mypackage\setup.py
py37 inst-nodeps: D:\mypackage\.tox\.tmp\package\1\mypackage-1.0.0.zip
ERROR: got KeyboardInterrupt signal
_____________________________________________________________________ summary
  py37: commands succeeded
ERROR:   flake8: undefined
@schlamar schlamar added the bug:normal affects many people or has quite an impact label Nov 11, 2019
@asottile
Copy link
Contributor

looks like the except KeyboardInterrupt I added there needs to be applied more broadly, there's more setup steps that this can trigger on (confirming this bug, I hit this on stream yesterday as well)

@gaborbernat
Copy link
Member

🤔 feel free to fill a PR 👍

@asottile
Copy link
Contributor

ah mine was slightly different and I haven't had time to dig into it, same class of problem though vid

@gaborbernat
Copy link
Member

Feel free to open a PR against master and fix it. My available efforts at the moment are aimed at fixing this as part of #1394, but that probably will take a while (ETA September).

@gnikonorov
Copy link
Contributor

It looks like this still happens off of head. @gaborbernat do you mind if I make a PR?

gnikonorov:~/tox$ tox -e py37
.package create: /home/gnikonorov/tox/.tox/.package
.package installdeps: setuptools >= 40.0.4, setuptools_scm >= 2.0.0, <4, wheel >= 0.29.0
py37 create: /home/gnikonorov/tox/.tox/py37
py37 installdeps: pip >= 19.3.1
^CERROR: got KeyboardInterrupt signal
_________________________________________________________________________________________________________________ summary __________________________________________________________________________________________________________________
  py37: commands succeeded
  congratulations :)
gnikonorov:~/tox$ tox -e py37
py37 create: /home/gnikonorov/tox/.tox/py37
py37 installdeps: pip >= 19.3.1
py37 inst: /home/gnikonorov/tox/.tox/.tmp/package/1/tox-3.20.2.dev11+g649c6c0.tar.gz
^CERROR: got KeyboardInterrupt signal
_________________________________________________________________________________________________________________ summary __________________________________________________________________________________________________________________
  py37: commands succeeded
  congratulations :)
gnikonorov:~/tox$ tox -e py37
py37 inst-nodeps: /home/gnikonorov/tox/.tox/.tmp/package/1/tox-3.20.2.dev11+g649c6c0.tar.gz
^CERROR: got KeyboardInterrupt signal
_________________________________________________________________________________________________________________ summary __________________________________________________________________________________________________________________
  py37: commands succeeded
  congratulations :)
gnikonorov:~/tox$

@gaborbernat
Copy link
Member

Go ahead.

@gnikonorov
Copy link
Contributor

Thank you @gaborbernat ! I should have a PR up soon

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug:normal affects many people or has quite an impact
Projects
None yet
4 participants