Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on itself? #355

Closed
0-wiz-0 opened this issue May 6, 2023 · 3 comments · Fixed by #361
Closed

Dependency on itself? #355

0-wiz-0 opened this issue May 6, 2023 · 3 comments · Fixed by #361

Comments

@0-wiz-0
Copy link
Contributor

0-wiz-0 commented May 6, 2023

I don't understand this line:

"sphinx-autodoc-typehints>=1.23.4",

This looks to me like the project has a dependency on itself, but on a newer version than currently exists (1.23.0).
Perhaps this is a misunderstanding, then I'd like an explanation what this means. Thank you!

@basnijholt
Copy link
Contributor

basnijholt commented May 21, 2023

I guess this is just some hack to install the dependencies in the docs building CI.

Read The Docs seems to be set up via the UI there.

For the maintainers, there is a toggle you can click to install the package itselfs.

Otherwise, create a .readthedocs.yaml file to the repo with appropriate setting.

@gaborbernat
Copy link
Member

This is a bug PR welcome to remove it.

@0-wiz-0
Copy link
Contributor Author

0-wiz-0 commented Jun 16, 2023

Thanks for the feedback, PR submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants