Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose subcrates default features in tower. #306

Closed
samscott89 opened this issue Jul 21, 2019 · 2 comments
Closed

Expose subcrates default features in tower. #306

samscott89 opened this issue Jul 21, 2019 · 2 comments

Comments

@samscott89
Copy link

samscott89 commented Jul 21, 2019 •
edited
Loading

Tower pulls in tower-buffer which has the log feature enabled by default. Would be good to re-expose this as a default feature in tower so it can be turned off if necessary. Presumably will be the same for other tower-* crates if/when tracing gets added to them.
@samscott89 samscott89 mentioned this issue Jul 21, 2019
Closed
@samscott89
Copy link
Author

Perhaps better to solve this in tracing - tokio-rs/tracing#204

@jonhoo
Copy link
Collaborator

jonhoo commented Mar 31, 2020

This is fixed by #431, and specifically #432.

@jonhoo jonhoo closed this as completed Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonhoo @samscott89