Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTS using WIS TTS does not process numbers #148

Closed
ingrove opened this issue Jun 5, 2023 · 6 comments
Closed

TTS using WIS TTS does not process numbers #148

ingrove opened this issue Jun 5, 2023 · 6 comments

Comments

@ingrove
Copy link

ingrove commented Jun 5, 2023

First, this is a great addition to Home Assistant! Thank you!

I've noticed that the TTS engine doesn't seem to process numbers. I have a few temperature related intent_scripts responding with numbers and the numbers are not processed. An example from watching the Tio terminal screen is:

WILLOW: Using WIS TTS URL 'https://infer.tovera.io/api/tts?speaker=CLB&text=it's currently 70.3 inside.'

Although the screen of the ESP32-S3-BOX displays "it's currently 70.3 inside", what is spoken by WIS TTS is "it's currently inside", without the numbers. I get the same result if I copy the URL in the browser of my PC running Windows. It skips the numbers.

@nikito
Copy link
Contributor

nikito commented Jun 5, 2023

This has actually been discussed on the WIS GitHub here: toverainc/willow-inference-server#78

There's a fix in the works, can see the details there 🙂

@kristiankielhofner
Copy link
Contributor

The fix is actually already deployed in the wisng branch. I just stood up a beta development server you can test against. Change both of your base inference server endpoints to https://wisng.tovera.io and you should hear numbers with TTS.

@ingrove
Copy link
Author

ingrove commented Jun 5, 2023

Thank you for the update. It seems there is still a problem with numbers that include decimals. Whole numbers like 68 work fine, however something like 68.9 is silent on the number.

https://wisng.tovera.io/api/tts?speaker=CLB&text=it's currently 68.9 inside.

@nikito
Copy link
Contributor

nikito commented Jun 5, 2023

Just tested the above and can confirm the same behavior on my local instance.

@nikito
Copy link
Contributor

nikito commented Jun 7, 2023

I created a PR to fix this, referenced above. I ensured it handles integer and float numbers, as well as negative and positive numbers. 😃

@kristiankielhofner
Copy link
Contributor

I added and comment regarding the removal of the currently unused function and I will be further testing and reviewing this today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants