Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update all comments/spec references to ES6 spec #27

Open
toshok opened this issue May 14, 2014 · 0 comments
Open

update all comments/spec references to ES6 spec #27

toshok opened this issue May 14, 2014 · 0 comments

Comments

@toshok
Copy link
Owner

toshok commented May 14, 2014

Right now there are a mix of references like // ECMA262: x.y.z.w and // ES6: x.y.z.w in comments around code, and we've directly copied (and converted to comments) the spec algorithms in numerous places.

Some of the ECMA262 references are to the ES5 spec, some to ES6. And ES6 recently changed all its numbering so the ES6 references are often out of date as well.

There are also a number of other more fundamental changes (addition of Symbol in ES6 caused all the ToStrings to become ToPropertyKeys when dealing with properties, and there are a host of other subtle changes.

All these need to be updated (and we need to put a stake in the ground as far as ES6 spec date is concerned and say "we implement ES6 as speced in the <date/version> draft." We can then update when we need to by looking at diffs between different draft versions and making only those changes, but what we have right now is kind of a mess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant