feat!: [#591] inject full socket address in configuration

not only the port.

Old:

```toml
[net]
port = 3001
```

New:

```toml
[net]
bind_address = "0.0.0.0:3001"
```

Author: josecelano

src/app.rs

@@ -57,8 +57,8 @@ pub async fn run(configuration: Configuration, api_version: &Version) -> Running
     let importer_torrent_info_update_interval = settings.tracker_statistics_importer.torrent_info_update_interval;
     let importer_port = settings.tracker_statistics_importer.port;
     // From [net] config
-    let net_ip = "0.0.0.0".to_string();
-    let net_port = settings.net.port;
+    let net_ip = settings.net.bind_address.ip().to_string();
+    let net_port = settings.net.bind_address.port();
     let opt_net_tsl = settings.net.tsl.clone();
 
     // IMPORTANT: drop settings before starting server to avoid read locks that

src/config/mod.rs

@@ -354,7 +354,7 @@ mod tests {
                                 token_valid_seconds = 7257600
 
                                 [net]
-                                port = 3001
+                                bind_address = "0.0.0.0:3001"
 
                                 [auth]
                                 email_on_signup = "optional"

src/config/v1/net.rs

@@ -1,3 +1,5 @@
+use std::net::{IpAddr, Ipv4Addr, SocketAddr};
+
 use serde::{Deserialize, Serialize};
 use url::Url;
 
@@ -11,13 +13,16 @@ use crate::config::Tsl;
 /// via port 443, which is a very common setup.
 #[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
 pub struct Network {
-    /// The port to listen on. Default to `3001`.
-    #[serde(default = "Network::default_port")]
-    pub port: u16,
     /// The base URL for the API. For example: `http://localhost`.
     /// If not set, the base URL will be inferred from the request.
     #[serde(default = "Network::default_base_url")]
     pub base_url: Option<Url>,
+    /// The address the tracker will bind to.
+    /// The format is `ip:port`, for example `0.0.0.0:6969`. If you want to
+    /// listen to all interfaces, use `0.0.0.0`. If you want the operating
+    /// system to choose a random port, use port `0`.
+    #[serde(default = "Network::default_bind_address")]
+    pub bind_address: SocketAddr,
     /// TSL configuration.
     #[serde(default = "Network::default_tsl")]
     pub tsl: Option<Tsl>,
@@ -26,14 +31,22 @@ pub struct Network {
 impl Default for Network {
     fn default() -> Self {
         Self {
-            port: Self::default_port(),
+            bind_address: Self::default_bind_address(),
             base_url: Self::default_base_url(),
             tsl: Self::default_tsl(),
         }
     }
 }
 
 impl Network {
+    fn default_bind_address() -> SocketAddr {
+        SocketAddr::new(Self::default_ip(), Self::default_port())
+    }
+
+    fn default_ip() -> IpAddr {
+        IpAddr::V4(Ipv4Addr::new(0, 0, 0, 0))
+    }
+
     fn default_port() -> u16 {
         3001
     }

src/lib.rs

@@ -177,7 +177,7 @@
 //! token_valid_seconds = 7257600
 //!
 //! [net]
-//! port = 3001
+//! bind_address = "0.0.0.0:3001"
 //!
 //! [auth]
 //! email_on_signup = "optional"

src/web/api/client/v1/contexts/settings/mod.rs

@@ -1,5 +1,7 @@
 pub mod responses;
 
+use std::net::SocketAddr;
+
 use serde::{Deserialize, Serialize};
 use url::Url;
 
@@ -40,8 +42,8 @@ pub struct Tracker {
 
 #[derive(Deserialize, Serialize, PartialEq, Debug, Clone)]
 pub struct Network {
-    pub port: u16,
     pub base_url: Option<String>,
+    pub bind_address: SocketAddr,
 }
 
 #[derive(Deserialize, Serialize, PartialEq, Debug, Clone)]
@@ -141,8 +143,8 @@ impl From<DomainTracker> for Tracker {
 impl From<DomainNetwork> for Network {
     fn from(net: DomainNetwork) -> Self {
         Self {
-            port: net.port,
             base_url: net.base_url.map(|url_without_port| url_without_port.to_string()),
+            bind_address: net.bind_address,
         }
     }
 }

tests/common/contexts/settings/mod.rs

@@ -1,5 +1,7 @@
 pub mod responses;
 
+use std::net::SocketAddr;
+
 use serde::{Deserialize, Serialize};
 use torrust_index::config::{
     Api as DomainApi, ApiToken, Auth as DomainAuth, Credentials as DomainCredentials, Database as DomainDatabase,
@@ -44,8 +46,8 @@ pub struct Tracker {
 
 #[derive(Deserialize, Serialize, PartialEq, Debug, Clone)]
 pub struct Network {
-    pub port: u16,
     pub base_url: Option<String>,
+    pub bind_address: SocketAddr,
 }
 
 #[derive(Deserialize, Serialize, PartialEq, Debug, Clone)]
@@ -154,7 +156,7 @@ impl From<DomainTracker> for Tracker {
 impl From<DomainNetwork> for Network {
     fn from(net: DomainNetwork) -> Self {
         Self {
-            port: net.port,
+            bind_address: net.bind_address,
             base_url: net.base_url.as_ref().map(std::string::ToString::to_string),
         }
     }

tests/environments/isolated.rs

@@ -1,3 +1,5 @@
+use std::net::{IpAddr, Ipv4Addr, SocketAddr};
+
 use tempfile::TempDir;
 use torrust_index::config;
 use torrust_index::config::{LogLevel, FREE_PORT};
@@ -76,7 +78,7 @@ fn ephemeral(temp_dir: &TempDir) -> config::Settings {
     configuration.logging.log_level = LogLevel::Off; // Change to `debug` for tests debugging
 
     // Ephemeral API port
-    configuration.net.port = FREE_PORT;
+    configuration.net.bind_address = SocketAddr::new(IpAddr::V4(Ipv4Addr::new(0, 0, 0, 0)), FREE_PORT);
 
     // Ephemeral Importer API port
     configuration.tracker_statistics_importer.port = FREE_PORT;