refactor: [#615] renamed error to be more human friendly

Author: mario-nt

src/errors.rs

@@ -109,7 +109,7 @@ pub enum ServiceError {
     InvalidTag,
 
     #[display(fmt = "Unauthorized action.")]
-    Unauthorized,
+    UnauthorizedAction,
 
     #[display(fmt = "This torrent already exists in our database.")]
     InfoHashAlreadyExists,
@@ -300,7 +300,7 @@ pub fn http_status_code_for_service_error(error: &ServiceError) -> StatusCode {
         ServiceError::MissingMandatoryMetadataFields => StatusCode::BAD_REQUEST,
         ServiceError::InvalidCategory => StatusCode::BAD_REQUEST,
         ServiceError::InvalidTag => StatusCode::BAD_REQUEST,
-        ServiceError::Unauthorized => StatusCode::FORBIDDEN,
+        ServiceError::UnauthorizedAction => StatusCode::FORBIDDEN,
         ServiceError::InfoHashAlreadyExists => StatusCode::BAD_REQUEST,
         ServiceError::CanonicalInfoHashAlreadyExists => StatusCode::CONFLICT,
         ServiceError::OriginalInfoHashAlreadyExists => StatusCode::CONFLICT,

src/services/authorization.rs

@@ -79,12 +79,14 @@ impl Service {
 
         let enforcer = self.casbin_enforcer.enforcer.read().await;
 
-        let authorize = enforcer.enforce((role, action)).map_err(|_| ServiceError::Unauthorized)?;
+        let authorize = enforcer
+            .enforce((role, action))
+            .map_err(|_| ServiceError::UnauthorizedAction)?;
 
         if authorize {
             Ok(())
         } else {
-            Err(ServiceError::Unauthorized)
+            Err(ServiceError::UnauthorizedAction)
         }
     }
 

src/services/torrent.rs

@@ -433,7 +433,7 @@ impl Index {
         // Check if user is owner or administrator
         // todo: move this to an authorization service.
         if !(torrent_listing.uploader == updater.username || updater.administrator) {
-            return Err(ServiceError::Unauthorized);
+            return Err(ServiceError::UnauthorizedAction);
         }
 
         self.torrent_info_repository