feat: [#445] new custom error and minor refactor to extractor

Author: mario-nt

src/errors.rs

@@ -148,6 +148,9 @@ pub enum ServiceError {
     #[display(fmt = "Database error.")]
     DatabaseError,
 
+    #[display(fmt = "You must be logged in!.")]
+    LoggedInUserNotFound,
+
     // Begin tracker errors
     #[display(fmt = "Sorry, we have an error with our tracker connection.")]
     TrackerOffline,
@@ -311,6 +314,7 @@ pub fn http_status_code_for_service_error(error: &ServiceError) -> StatusCode {
         ServiceError::TrackerUnknownResponse => StatusCode::INTERNAL_SERVER_ERROR,
         ServiceError::TorrentNotFoundInTracker => StatusCode::NOT_FOUND,
         ServiceError::InvalidTrackerToken => StatusCode::INTERNAL_SERVER_ERROR,
+        ServiceError::LoggedInUserNotFound => StatusCode::UNAUTHORIZED,
     }
 }
 

src/web/api/server/v1/extractors/user_id.rs

@@ -23,15 +23,15 @@ where
     async fn from_request_parts(parts: &mut Parts, state: &S) -> Result<Self, Self::Rejection> {
         let maybe_bearer_token = match bearer_token::Extract::from_request_parts(parts, state).await {
             Ok(maybe_bearer_token) => maybe_bearer_token.0,
-            Err(_) => return Err(ServiceError::Unauthorized.into_response()),
+            Err(_) => return Err(ServiceError::TokenNotFound.into_response()),
         };
 
         //Extracts the app state
         let app_data = Arc::from_ref(state);
 
         match app_data.auth.get_user_id_from_bearer_token(&maybe_bearer_token).await {
             Ok(user_id) => Ok(ExtractLoggedInUser(user_id)),
-            Err(_) => Err(ServiceError::Unauthorized.into_response()),
+            Err(_) => Err(ServiceError::LoggedInUserNotFound.into_response()),
         }
     }
 }