refactor: [#297] code cleanup

Author: mario-nt

components/torrent/TorrentCreationDateTab.vue

@@ -14,7 +14,7 @@
     <template v-if="!collapsed">
       <div class="flex flex-col w-full h-full p-6 grow bg-base-100 rounded-2xl">
         <template v-if="torrent.creation_date">
-          {{ unixTimeToHumanReadableUTC(torrent.creation_date) }}
+          {{ formatedDateFromTimestamp }}
         </template>
         <template v-else>
           <span class="italic text-neutral-content">No creation date provided.</span>
@@ -30,7 +30,7 @@ import { TorrentResponse } from "torrust-index-types-lib";
 import { PropType } from "vue";
 import { ref } from "#imports";
 import Markdown from "~/components/Markdown.vue";
-import { unixTimeToHumanReadableUTC } from "~/src/helpers/DateConverter";
+import { formatTimestamp } from "~/src/helpers/DateConverter";
 
 const collapsed = ref(false);
 
@@ -41,6 +41,8 @@ const props = defineProps({
   }
 });
 
+const formatedDateFromTimestamp = formatTimestamp(props.torrent.creation_date);
+
 </script>
 
 <style scoped>

src/helpers/DateConverter.ts

@@ -1,22 +1,21 @@
-type UnixTime = number;
+type UnixTimestamp = number;
+type FormattedDate = string;
 
 class InvalidDateError extends Error {}
-class WrongTimestamp extends Error {}
 
-// Takes the date in seconds from Epoch time and converts it to human readable format.
+/**
+ * Takes the date in seconds from Unix Epoch time and converts it to human readable format.
+ *
+ * For example: 1701688451 -> "Mon Dec 04 2023"
+ */
 
-export function unixTimeToHumanReadableUTC (creationDate: UnixTime) {
-  let milliseconds;
-  let convertedDate;
-  try {
-    milliseconds = creationDate * 1000;
-  } catch (error) {
-    return new WrongTimestamp(`Could not convert ${creationDate} to milliseconds`);
-  }
-  try {
-    convertedDate = new Date(milliseconds);
-  } catch (error) {
-    return new InvalidDateError(`Could not create a new date from ${milliseconds}`);
-  }
-  return !isNaN(convertedDate.valueOf()) ? convertedDate.toDateString() : new InvalidDateError(`Could not create a valid date from ${milliseconds}`);
+export function formatTimestamp (creationDate: UnixTimestamp): FormattedDate | Error {
+  const milliseconds = creationDate * 1000;
+
+  const convertedDate = new Date(milliseconds);
+
+  return isNaN(convertedDate.valueOf())
+    ? new InvalidDateError(
+      `Invalid date. Could not create a new date from timestamp value: ${creationDate}`)
+    : convertedDate.toDateString();
 }